Fix/issue 3913 #4436
Merged
Fix/issue 3913 #4436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If the design_name is set to a name that is already in the design_list, then that becomes the current design. - Update test_01_Design.py and improve coverage. - Remove some dependence on naming between unit tests.
- If the design_name is set to a name that is already in the design_list, then that becomes the current design. - Update test_01_Design.py and improve coverage. - Remove some dependence on naming between unit tests.
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4436 +/- ##
==========================================
+ Coverage 81.44% 81.46% +0.01%
==========================================
Files 109 109
Lines 53581 53583 +2
==========================================
+ Hits 43638 43649 +11
+ Misses 9943 9934 -9 |
Samuelopez-ansys
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
LGTM. @maxcapodi78 Do we need the timeout? It is hardcoded, I understand the reason, but not sure if this is safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
design_nameto a valid design name in the project now sets that one to the active design.