Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/issue 3913 #4436

Merged
merged 3 commits into from
Apr 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions _unittest/test_01_Design.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,17 @@ def test_app(self):
assert self.aedtapp

def test_01_designname(self):
self.aedtapp.design_name = "myname"
assert self.aedtapp.design_name == "myname"
# TODO: Remove subsequent dependence on string "myname"
design_names = ["myname", "design2"]
self.aedtapp.design_name = design_names[0] # Change the design name.
assert self.aedtapp.design_name == design_names[0]
self.aedtapp.insert_design(design_names[1]) # Insert a new design
assert self.aedtapp.design_name == design_names[1]
self.aedtapp.design_name = design_names[0] # Change current design back.
assert len(self.aedtapp.design_list) == 2 # Make sure there are still 2 designs.
assert self.aedtapp.design_list[0] == design_names[0] # Make sure the name is correct.
self.aedtapp.delete_design(design_names[1]) # Delete the 2nd design
assert len(self.aedtapp.design_list) == 1

def test_01_version_id(self):
assert self.aedtapp.aedt_version_id
Expand Down
25 changes: 15 additions & 10 deletions pyaedt/application/Design.py
Original file line number Diff line number Diff line change
Expand Up @@ -631,16 +631,21 @@ def design_name(self, new_name):
if ";" in new_name:
new_name = new_name.split(";")[1]

self.odesign.RenameDesignInstance(self.design_name, new_name)
timeout = 5.0
timestep = 0.1
while new_name not in [
i.GetName() if ";" not in i.GetName() else i.GetName().split(";")[1]
for i in list(self._oproject.GetDesigns())
]:
time.sleep(timestep)
timeout -= timestep
assert timeout >= 0
# If new_name is the name of an existing design, set the current
# design to this design.
if new_name in self.design_list:
self.set_active_design(new_name)
else: # Otherwise rename the current design.
self.odesign.RenameDesignInstance(self.design_name, new_name)
timeout = 5.0
timestep = 0.1
while new_name not in [
i.GetName() if ";" not in i.GetName() else i.GetName().split(";")[1]
for i in list(self._oproject.GetDesigns())
]:
time.sleep(timestep)
timeout -= timestep
assert timeout >= 0

@property
def design_list(self):
Expand Down
Loading