Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve h3d layout methods #4451

Merged
merged 15 commits into from
Apr 4, 2024
Merged

Improve h3d layout methods #4451

merged 15 commits into from
Apr 4, 2024

Conversation

maxcapodi78
Copy link
Collaborator

@maxcapodi78 maxcapodi78 commented Apr 3, 2024

add few methods to hfss3dlayout.py:

  • dissolve_component
  • create_pec_on_component_by_nets
  • modeler.create_components_on_pins
    Added new property to set_solderball method to add an offset for the port in component solderball.
    added method create_components_on_pins

maxcapodi78 added 2 commits April 2, 2024 15:10
- dissolve_component
- create_pec_on_component_by_nets
- modeler.create_components_on_pins
Added new property to set_solderball method to add an offset for the port in component solderball.
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.51%. Comparing base (225652e) to head (4eebec7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4451   +/-   ##
=======================================
  Coverage   81.50%   81.51%           
=======================================
  Files         109      109           
  Lines       53210    53240   +30     
=======================================
+ Hits        43368    43396   +28     
- Misses       9842     9844    +2     

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxcapodi78 maxcapodi78 enabled auto-merge (squash) April 4, 2024 12:51
@maxcapodi78 maxcapodi78 disabled auto-merge April 4, 2024 15:06
@maxcapodi78 maxcapodi78 merged commit 3012455 into main Apr 4, 2024
15 checks passed
@maxcapodi78 maxcapodi78 deleted the improve_h3d_layout_methods branch April 4, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants