Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pdf #4468

Merged
merged 16 commits into from
Apr 9, 2024
Merged

Fix pdf #4468

merged 16 commits into from
Apr 9, 2024

Conversation

Samuelopez-ansys
Copy link
Member

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@Samuelopez-ansys Samuelopez-ansys marked this pull request as draft April 5, 2024 14:59
@github-actions github-actions bot added documentation maintenance Package and maintenance related bug Something isn't working labels Apr 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.43%. Comparing base (dbf4a89) to head (252d870).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4468      +/-   ##
==========================================
- Coverage   81.43%   81.43%   -0.01%     
==========================================
  Files         110      110              
  Lines       53482    53482              
==========================================
- Hits        43552    43551       -1     
- Misses       9930     9931       +1     

@SMoraisAnsys SMoraisAnsys marked this pull request as ready for review April 9, 2024 14:50
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Closely related to #4284 which (hopefully) will be accepted soon

@Samuelopez-ansys Samuelopez-ansys merged commit b3f2805 into main Apr 9, 2024
15 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix_pdf branch April 9, 2024 16:10
This was referenced Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants