Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced default HFSS Solution type to Terminal for version >= 2024.1 #4484

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

maxcapodi78
Copy link
Collaborator

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@MaxJPRey
Copy link
Collaborator

@maxcapodi78 In the title of the PR, you mention that the default Solution type should be Terminal.
But in the code it seems it is Modal.

It is just to be sure that it is expected.

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.42%. Comparing base (7680ef4) to head (47d3267).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4484      +/-   ##
==========================================
- Coverage   81.43%   81.42%   -0.01%     
==========================================
  Files         110      110              
  Lines       53482    53484       +2     
==========================================
- Hits        43553    43552       -1     
- Misses       9929     9932       +3     

@Samuelopez-ansys
Copy link
Member

@MaxJPRey You can see in desing_types that @maxcapodi78 changed the default HFSS design, the main reason is because from AEDT 2023R2, the default is Terminal.

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit 9d05add into main Apr 12, 2024
15 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the change_default_hfss branch April 12, 2024 06:20
@MaxJPRey
Copy link
Collaborator

@MaxJPRey You can see in desing_types that @maxcapodi78 changed the default HFSS design, the main reason is because from AEDT 2023R2, the default is Terminal.

Got it. Thanks @Samuelopez-ansys !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants