Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced default HFSS Solution type to Terminal for version >= 2024.1 #4484

Merged
merged 2 commits into from
Apr 12, 2024
Merged

replaced default HFSS Solution type to Terminal for version >= 2024.1 #4484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b16be1e
replaced default HFSS Solution type to Terminal for version >= 2024.1
Apr 10, 2024
47d3267
replaced default HFSS Solution type to Terminal for version >= 2024.1
Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _unittest/test_12_PostProcessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def ami_test(add_app, q3dtest):

@pytest.fixture(scope="class")
def array_test(add_app, q3dtest):
app = add_app(project_name=array, subfolder=test_subfolder)
app = add_app(project_name=array, subfolder=test_subfolder, solution_type="Modal")
return app


Expand Down
2 changes: 1 addition & 1 deletion _unittest/test_16_3d_stackup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

@pytest.fixture(scope="class")
def aedtapp(add_app):
app = add_app(project_name="Test_16")
app = add_app(project_name="Test_16", solution_type="Modal")
return app


Expand Down
2 changes: 1 addition & 1 deletion _unittest/test_20_HFSS.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1325,7 +1325,7 @@ def test_53_import_source_excitation(self, add_app):
aedtapp.close_project(save_project=False)

def test_54_assign_symmetry(self, add_app):
aedtapp = add_app(project_name="test_54")
aedtapp = add_app(project_name="test_54", solution_type="Modal")
aedtapp.modeler.create_box([0, -100, 0], [200, 200, 200], name="SymmetryForFaces")
ids = [i.id for i in aedtapp.modeler["SymmetryForFaces"].faces]
assert aedtapp.assign_symmetry(ids)
Expand Down
2 changes: 1 addition & 1 deletion _unittest/test_launch_desktop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def test_run_desktop_maxwell2d(self):
def test_run_desktop_hfss(self):
aedtapp = Hfss()
assert aedtapp.design_type == "HFSS"
assert "Modal" in aedtapp.solution_type
assert "Terminal" in aedtapp.solution_type

def test_run_desktop_maxwell3d(self):
aedtapp = Maxwell3d()
Expand Down
2 changes: 1 addition & 1 deletion _unittest_ironpython/run_unittests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def test_run_desktop_maxwell2d(self):
def test_run_desktop_hfss(self):
aedtapp = Hfss()
self.assertTrue(aedtapp.design_type == "HFSS")
self.assertTrue("Modal" in aedtapp.solution_type)
self.assertTrue("Terminal" in aedtapp.solution_type)
self.assertTrue(aedtapp.modeler)
self.assertTrue(aedtapp.post)
self.assertTrue(aedtapp.materials)
Expand Down
2 changes: 2 additions & 0 deletions pyaedt/application/Design.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3283,6 +3283,8 @@ def _insert_design(self, design_type, design_name=None):
else:
if design_type == "HFSS" and self._aedt_version < "2021.2":
new_design = self._oproject.InsertDesign(design_type, unique_design_name, "DrivenModal", "")
elif design_type == "HFSS" and self._aedt_version < "2024.1":
new_design = self._oproject.InsertDesign(design_type, unique_design_name, "HFSS Modal Network", "")
else:
new_design = self._oproject.InsertDesign(
design_type, unique_design_name, self.default_solution_type, ""
Expand Down
2 changes: 1 addition & 1 deletion pyaedt/application/design_solutions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"Maxwell Circuit": "",
"2D Extractor": "Open",
"Q3D Extractor": "Q3D Extractor",
"HFSS": "HFSS Modal Network",
"HFSS": "HFSS Terminal Network",
"Icepak": "SteadyState",
"RMxprtSolution": "GRM",
"ModelCreation": "GRM",
Expand Down
Loading