fix: allow configuring apiVersion in Ingress Class resource #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gallardot
approved these changes
Jan 15, 2024
AlinsRan
approved these changes
Jan 18, 2024
AlinsRan
requested changes
Jan 18, 2024
| apiVersion: networking.k8s.io/v1 | ||
| {{- else }} | ||
| apiVersion: {{ .Values.config.kubernetes.ingressVersion }} |
There was a problem hiding this comment.
https://github.com/apache/apisix-ingress-controller/blob/master/conf/config-default.yaml#L72-L74
Are you sure you can use it directly?
networking/v1beta1 != networking.k8s.io/v1beta1
Signed-off-by: Ashish Tiwari <[email protected]>
|
@AlinsRan Can you review again? I made the changes/ |
AlinsRan
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apache/apisix-ingress-controller#2133