chore: Test more rounds for unsafeDataVia keeping order. #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
force-pushed
the
testunsafeDataViaMoreTimes
branch
from
e2d2ab9 to
247cda6
Compare
He-Pin
commented
Jan 5, 2025
| for (_ <- 0 until 64) { | ||
| SourceWithContext | ||
| .fromTuples(Source(data)).via( | ||
| FlowWithContext.unsafeOptionalDataVia( |
There was a problem hiding this comment.
this can fail too, fixed in #1681
He-Pin
added a commit
to He-Pin/incubator-pekko
that referenced
this pull request
Jan 5, 2025
(cherry picked from commit 2ee3745)
He-Pin
added a commit
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Run the testing more times for ordering validation.
Modification:
Run it 64 times
Result:
Test unsafeDataVia more times.
These tests are fast, so no much overhead.