Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix occasional ordering issue in FlowWithContext#unsafeOptionalDataVia #1681

Merged
merged 2 commits into from
Jan 5, 2025

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Jan 5, 2025

Motivation:
Find this when run #1680
Fix: https://github.com/apache/pekko/actions/runs/12616423403/job/35157651854#step:7:20761

Modification:
port the fix in #1611

Result:
ran 1024 times, works.

@He-Pin He-Pin requested review from pjfanning and mdedetrich January 5, 2025 06:23
@He-Pin He-Pin added t:stream Pekko Streams bug Something isn't working backport labels Jan 5, 2025
@He-Pin He-Pin added this to the 1.2.0 milestone Jan 5, 2025
@He-Pin He-Pin changed the title fix: Fix flask ordering in FlowWithContext#unsafeOptionalDataVia fix: Fix occasional ordering issue in FlowWithContext#unsafeOptionalDataVia Jan 5, 2025
Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@He-Pin He-Pin merged commit 477fd39 into apache:main Jan 5, 2025
9 checks passed
@He-Pin He-Pin deleted the unsafeOptionalDataVia branch January 5, 2025 16:10
He-Pin added a commit to He-Pin/incubator-pekko that referenced this pull request Jan 5, 2025
…ataVia (apache#1681)

* chore: Test more rounds for unsafeDataVia keeping order.

* fix: Fix flask ordering in FlowWithContext#unsafeOptionalDataVia operator.

(cherry picked from commit 477fd39)
He-Pin added a commit that referenced this pull request Jan 8, 2025
…ataVia (#1681) (#1684)

* chore: Test more rounds for unsafeDataVia keeping order.

* fix: Fix flask ordering in FlowWithContext#unsafeOptionalDataVia operator.

(cherry picked from commit 477fd39)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Something isn't working t:stream Pekko Streams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants