This repository has been archived by the owner on Jan 23, 2025. It is now read-only.
feat(ec2): name support for the launch template #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikpivkin
force-pushed
the
launch-template
branch
from
f93f60a to
c439ed6
Compare
1 task
simar7
reviewed
Jan 4, 2024
Comment on lines
+26
to
+28
| // If the user leaves the name blank, Terraform will automatically generate a unique name | ||
| case "aws_launch_template": | ||
| presets["name"] = cty.StringVal(uuid.New().String()) |
There was a problem hiding this comment.
We need to generate some unique value in case the user did not pass the name argument.
simar7
approved these changes
Jan 10, 2024
simar7
force-pushed
the
launch-template
branch
from
c439ed6 to
b19fd5e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See aquasecurity/trivy#5793