Create ButtonMouseControl.ino #13
Conversation
There was a problem hiding this comment.
DONE The examples must be placed under the examples folder in a subfolder that matches the sketch name exactly:
Mouse
|_examples
|_ButtonMouseControl
|_ButtonMouseControl.ino
Reference:
https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification#library-examples
Co-Authored-By: per1234 <[email protected]>
Co-Authored-By: per1234 <[email protected]>
|
One thing to note is that this sketch already comes bundled with the Arduino IDE (and Arduino Web Editor) under File > Examples > 09.USB > Mouse. It does make sense to bundle the examples with the library since the IDE bundled examples are not available to arduino-cli and Arduino Pro IDE users. I don't like the idea of having duplicate code to maintain, but it also could be problematic to remove the built-in sketches since there are likely tutorials that point people to that menu path. I suppose we could replace the content of the built in sketches with a comment like: // This example has been moved to File > Examples > Mouse > ButtonMouseControl |
|
I did it thinking that there has to be a consistent codebase throughout, What you have mentioned Is one possible solution to the issue. |
|
@per1234 so is it ready to merge? |
|
The example itself looks good to me, but I think it would be good to have a decision made regarding how to handle the situation with the built-in examples before moving forward with adding the examples to the Mouse and Keyboard libraries. I'm not the one to make the decisions on these things. I just added my thoughts in hope they will be of some use. |
|
@per1234 Thanks for the insight! Hoping there will be a decision soon. |
Co-Authored-By: per1234 <[email protected]>
Co-Authored-By: per1234 <[email protected]>
|
Oh okay! will keep in mind. |
There was a problem hiding this comment.
I recommend also adding the layout and schematic files from https://github.com/arduino/Arduino/tree/master/build/shared/examples/09.USB/Mouse/ButtonMouseControl
|
@per1234 I've added the files, please let me know if there is anything else. |
|
|
No description provided.