Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use [email protected] #2362

Closed
wants to merge 1 commit into from
Closed

chore: use [email protected] #2362

wants to merge 1 commit into from

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Feb 9, 2024 •
edited
Loading

Motivation

  • use @theia/[email protected] APIs,
  • remove unused survey service and the corresponding arduino.survey.notification setting, and
  • update language translation VSIX versions to VS Code compatibility (supported by Theia IDE).

Change description

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself topic: theia Related to the Theia IDE framework labels Feb 9, 2024
@kittaakos kittaakos mentioned this pull request Feb 9, 2024
Closed
4 tasks
@kittaakos kittaakos force-pushed the use-theia-1.46.1 branch 2 times, most recently from ed57710 to 167c3bd Compare February 23, 2024 09:14
chore: use [email protected]
de5b91f 
Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos marked this pull request as ready for review February 23, 2024 14:51
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Akos Kitta seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

giacomocusinato added a commit that referenced this pull request Mar 11, 2025
@giacomocusinato
chore: use [email protected]
8291626 
Use changes from #2362 and rebase on main branch
@giacomocusinato giacomocusinato mentioned this pull request Mar 13, 2025
Merged
4 tasks
giacomocusinato added a commit that referenced this pull request Mar 24, 2025
@giacomocusinato
chore: use [email protected]
0082e87 
Use changes from #2362 and rebase on main branch
@giacomocusinato
Copy link
Collaborator

Closed in favour of #2654

@per1234 per1234 added the conclusion: duplicate Has already been submitted label Mar 25, 2025
giacomocusinato added a commit that referenced this pull request Mar 27, 2025
@giacomocusinato
fixup! chore: use [email protected]
2a00d6c 
Use changes from #2362 and rebase on main branch
giacomocusinato added a commit that referenced this pull request Mar 28, 2025
@giacomocusinato
chore: use [email protected]
8053c55 
Use changes from #2362 and rebase on main branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giacomocusinato giacomocusinato Awaiting requested review from giacomocusinato

@davegarthsimpson davegarthsimpson Awaiting requested review from davegarthsimpson

Assignees
No one assigned
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself topic: theia Related to the Theia IDE framework type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kittaakos @CLAassistant @giacomocusinato @per1234