feat: use [email protected]
#2654
Conversation
giacomocusinato
force-pushed
the
use-theia-latest
branch
from
4d57906 to
6e9577a
Compare
giacomocusinato
force-pushed
the
use-theia-latest
branch
from
7868bdb to
cb91633
Compare
giacomocusinato
added
topic: code
giacomocusinato
force-pushed
the
use-theia-latest
branch
5 times, most recently
from
46637f4 to
8a4b727
Compare
giacomocusinato
force-pushed
the
use-theia-latest
branch
5 times, most recently
from
a69a4e5 to
3adbd1d
Compare
giacomocusinato
added
type: enhancement
arduino-ide-extension/src/electron-browser/theia/core/electron-main-menu-factory.ts
Outdated
Show resolved
Hide resolved
arduino-ide-extension/src/electron-main/theia/electron-main-application.ts
Outdated
Show resolved
Hide resolved
electron-app/package.json
Outdated
| "vscode-builtin-cpp": "https://open-vsx.org/api/vscode/cpp/1.52.1/file/vscode.cpp-1.52.1.vsix", | ||
| "vscode-arduino-api": "https://github.com/dankeboy36/vscode-arduino-api/releases/download/0.1.2/vscode-arduino-api-0.1.2.vsix", | ||
| "vscode-builtin-cpp": "https://open-vsx.org/api/vscode/cpp/1.88.1/file/vscode.cpp-1.88.1.vsix", | ||
| "vscode-arduino-api": "https://github.com/dankeboy36/vscode-arduino-api/releases/download/0.2.1/vscode-arduino-api-0.2.1.vsix", |
There was a problem hiding this comment.
| "vscode-arduino-api": "https://github.com/dankeboy36/vscode-arduino-api/releases/download/0.2.1/vscode-arduino-api-0.2.1.vsix", | |
| "vscode-arduino-api": "https://github.com/dankeboy36/vscode-arduino-api/releases/download/0.1.2/vscode-arduino-api-0.1.2.vsix", |
Thank you! However, it depends on your release plan. I would be happy to see the new API integrated into the IDE nightly, and everything should be compatible, but I can't guarantee anything. If any issues arise, I'm available to help resolve them, or you can revert to a previous version if needed.
There was a problem hiding this comment.
Ideally we would merge this PR once ready and release next week after a weekend of nightly test.
I won't mind also postponing the vscode-arduino-api update to the release after this one, to allow for longer nightly testing
There was a problem hiding this comment.
I propose reverting the changes for now, and after the IDE release, I will create a follow-up PR. Thank you!
|
The Theia update is supposed to fix #2148. It would make sense to verify if the CLI daemon can reconnect. The LS reconnection will fail. See here: Update: I have not verified it, but I assume IDE has to create a new daemon instance on reconnect, therefore the instance number will change. |
Use changes from #2362 and rebase on main branch
Remove `EditorCommandContribution` override, since https://redirect.github.com/eclipse-theia/theia/pull/13683 fixed the unwanted save on startup
Note: align SidebarBottomMenuWidget with Theia new API and HTML structure
Electron version is now pinned, so replace caret only if found
giacomocusinato
force-pushed
the
use-theia-latest
branch
from
e6cf3cf to
f3a2eb9
Compare
Motivation
Use
[email protected].Note that newer versions are currently not working because of ESM incompatibilty. See theia issue and Prototype ESM-only package workaround for unbundled back end
Change description
Based on #2362
The first commit includes all changes from #2363 rebased into main branch.
Main changes needed for upgrades after
[email protected]:EditorCommandContributionoverride (1fa0def), since Theia runs save on app startup if"editor.autoSave": "on"is configured in the settings.json eclipse-theia/theia#8722 has been fixed in[email protected]through this PR[email protected]; this was needed for some incompatibility with electron builder. After the upgrade, some custom package resolutions is required, (see issue)TreeViewWidgetpatches since[email protected]. See fix: alignviewsWelcomebehavior to VS Code #2543Other information
Know issues:
onPointerEnterCapture. Tracked in https://redirect.github.com/eclipse-theia/theia/issues/14633Reviewer checklist