-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add interface TE twamp-light with fallback knobs #4935
Merged
gmuloc
merged 12 commits into
aristanetworks:devel
from
emilarista:eos_cli_config_gen/if-te-twamp-fallback
Feb 6, 2025
Merged
Feat(eos_cli_config_gen): Add interface TE twamp-light with fallback knobs #4935
gmuloc
merged 12 commits into
aristanetworks:devel
from
emilarista:eos_cli_config_gen/if-te-twamp-fallback
Feb 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4935
# Activate the virtual environment
source test-avd-pr-4935/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/emilarista/ansible-avd.git@eos_cli_config_gen/if-te-twamp-fallback#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/emilarista/ansible-avd.git#/ansible_collections/arista/avd/,eos_cli_config_gen/if-te-twamp-fallback --force
# Optional: Install AVD examples
cd test-avd-pr-4935
ansible-playbook arista.avd.install_examples |
ClausHolbechArista
requested changes
Jan 28, 2025
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md
Show resolved
Hide resolved
4273159
to
d6a0e21
Compare
for more information, see https://pre-commit.ci
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md
Show resolved
Hide resolved
alexeygorbunov
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MaheshGSLAB
reviewed
Jan 30, 2025
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md
Outdated
Show resolved
Hide resolved
ClausHolbechArista
requested changes
Feb 4, 2025
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/port_channel_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/port_channel_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/port_channel_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
Feb 6, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Feat(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…knobs
Change Summary
Add dynamic min-delay with twamp-light and fallback knobs.
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
How to test
Tested with molecule and on device.
Checklist
Repository Checklist