Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_designs): structured_config for network_services router_bgp #4961

Conversation

ClausHolbechArista
Copy link
Contributor

Refactor(eos_designs): structured_config for network_services router_bgp

@ClausHolbechArista ClausHolbechArista requested review from a team as code owners January 31, 2025 14:13
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4961
# Activate the virtual environment
source test-avd-pr-4961/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/network-services-router-bgp-output-classes#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/network-services-router-bgp-output-classes --force
# Optional: Install AVD examples
cd test-avd-pr-4961
ansible-playbook arista.avd.install_examples

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Jan 31, 2025
@ClausHolbechArista ClausHolbechArista force-pushed the refactor/eos_designs/network-services-router-bgp-output-classes branch from fb6525a to 92e0105 Compare January 31, 2025 15:24
@github-actions github-actions bot removed the state: conflict PR with conflict label Jan 31, 2025
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: conflict PR with conflict labels Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ClausHolbechArista ClausHolbechArista force-pushed the refactor/eos_designs/network-services-router-bgp-output-classes branch from 4afc265 to fd9b6ef Compare February 4, 2025 12:59
@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 4, 2025
Copy link

github-actions bot commented Feb 4, 2025

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ClausHolbechArista ClausHolbechArista force-pushed the refactor/eos_designs/network-services-router-bgp-output-classes branch 2 times, most recently from cfae068 to 03357e9 Compare February 5, 2025 18:01
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left to review router_bgp and avd_models

Copy link

github-actions bot commented Feb 6, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Feb 6, 2025
@ClausHolbechArista ClausHolbechArista force-pushed the refactor/eos_designs/network-services-router-bgp-output-classes branch from 3a1a39d to e6227fb Compare February 6, 2025 14:34
@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link

github-actions bot commented Feb 7, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Feb 7, 2025
python-avd/pyavd/_schema/models/avd_model.py Outdated Show resolved Hide resolved
@ClausHolbechArista ClausHolbechArista force-pushed the refactor/eos_designs/network-services-router-bgp-output-classes branch from a7d9cb0 to d3fb7b2 Compare February 7, 2025 10:48
Copy link

github-actions bot commented Feb 7, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Feb 7, 2025
@ClausHolbechArista ClausHolbechArista force-pushed the refactor/eos_designs/network-services-router-bgp-output-classes branch from fa52f7a to 9647b81 Compare February 7, 2025 13:38
@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 7, 2025
Copy link

github-actions bot commented Feb 7, 2025

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - reviewed molecule artifacts.
We will be improving error messages over time, for now they convey to correct errors to users.

@carlbuchmann carlbuchmann merged commit 06262b5 into aristanetworks:devel Feb 7, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants