-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_designs): structured_config for network_services router_bgp #4961
Refactor(eos_designs): structured_config for network_services router_bgp #4961
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4961
# Activate the virtual environment
source test-avd-pr-4961/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/network-services-router-bgp-output-classes#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/network-services-router-bgp-output-classes --force
# Optional: Install AVD examples
cd test-avd-pr-4961
ansible-playbook arista.avd.install_examples |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
fb6525a
to
92e0105
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
4afc265
to
fd9b6ef
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
cfae068
to
03357e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left to review router_bgp and avd_models
python-avd/pyavd/_eos_designs/structured_config/network_services/router_bgp.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/router_bgp.py
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/router_bgp.py
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/router_bgp.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/vlan_interfaces.py
Outdated
Show resolved
Hide resolved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
3a1a39d
to
e6227fb
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
a7d9cb0
to
d3fb7b2
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…es/vlan_interfaces.py Co-authored-by: Guillaume Mulocher <[email protected]>
for more information, see https://pre-commit.ci
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
fa52f7a
to
9647b81
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - reviewed molecule artifacts.
We will be improving error messages over time, for now they convey to correct errors to users.
Refactor(eos_designs): structured_config for network_services router_bgp