fix: remove dup licenses acceptance #933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palpatim
approved these changes
Feb 11, 2025
atierian
approved these changes
Feb 12, 2025
Siqi-Shan
added a commit
that referenced
this pull request
Feb 12, 2025
* fix: remove dup licenses acceptance * chore: add comments to clarify command behaviors * chore: add comment
Siqi-Shan
added a commit
that referenced
this pull request
Feb 13, 2025
* feat: add regionalized build spec for three canaries * chore: auto generate canary build spec files * chore: add canary build spec generation to pre commit hook * chore: remove licenses from android build spec * fix: remove dup licenses acceptance (#933) * fix: remove dup licenses acceptance * chore: add comments to clarify command behaviors * chore: add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Removed first global licenses acceptance to avoid possible 304 error when running tests.
Codegen Paramaters Changed or Added
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.