Skip to content

chore: Pin vscode-vue-languageservice to 0.27.26 #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Conversation

wlee221
Copy link
Contributor

@wlee221 wlee221 commented Oct 5, 2021

Issue #, if available:

Description of changes: I was able to narrow down the recent vue failures to upstream dependency vscode-vue-languageservice. vue-tsc depends on vscode-vue-languageservice@^0.27.0, which got bumped as its semver is denoted by carets. Pinning this version to 0.27.26 to resolve CI. Will check their repo for related issues.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@wlee221 wlee221 temporarily deployed to ci October 5, 2021 18:35 Inactive
@wlee221 wlee221 temporarily deployed to ci October 5, 2021 18:35 Inactive
@wlee221 wlee221 temporarily deployed to ci October 5, 2021 18:35 Inactive
@wlee221
Copy link
Contributor Author

wlee221 commented Oct 5, 2021

Looks very related: vuejs/language-tools#547, though the fix for that has been released in 0.27.28. I might try creating a smaller repro and open a new issue when I get time...

Copy link
Contributor

@eddiekeller eddiekeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it worked!

Copy link
Contributor

@ericclemmons ericclemmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 !

Copy link
Contributor

@zchenwei zchenwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@wlee221 wlee221 merged commit 440b677 into main Oct 5, 2021
@wlee221 wlee221 deleted the fix-vue-build branch October 5, 2021 18:59
@wlee221 wlee221 mentioned this pull request Jun 8, 2022
2 tasks
thaddmt pushed a commit that referenced this pull request Apr 7, 2023
Sync amplify-ui to amplify-ui-staging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants