Feature/kak/drag tour destinations#1112 #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flibbertigibbet
force-pushed
the
feature/kak/drag-tour-destinations#1112
branch
from
a1bc109 to
ef6cdb0
Compare
|
build again |
3 tasks
flibbertigibbet
force-pushed
the
feature/kak/drag-tour-destinations#1112
branch
2 times, most recently
from
cead4ab to
e976ff4
Compare
|
This has been rebased on #1156 and should be testable again now. |
Pass full tour object to template.
Add library for reordering HTML lists. Also pick up minor package updates.
Fix loading jQuery Sortable plugin.
When user drags to reorder tour destination list, update directions. Closes azavea#1112.
Fix loading spinner not showing after redesign/moving tour sidebar element in DOM.
KlaasH
approved these changes
Oct 15, 2019
Comment on lines
+57
to
+63
| if (tour.id !== tourId) { | ||
| tourId = tour.id; | ||
| destinations = tour.destinations; | ||
| } else { | ||
| // tour unchanged; preserve user assigned destination order | ||
| tour.destinations = destinations; | ||
| } |
There was a problem hiding this comment.
This is a nice detail, preserving their changes as much as we can.
flibbertigibbet
force-pushed
the
feature/kak/drag-tour-destinations#1112
branch
from
aa41e68 to
f0bf510
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Allow dragging tour destinations in sidebar to reorder them, which triggers refreshing the route to update the waypoint order and destination.
Notes
I based this PR on #1126. I'll rebase on
toursonce #1126 has merged.Testing Instructions
Closes #1112