Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sw-949] add mission client in spot wrapper #109

Merged
merged 11 commits into from
May 15, 2024

Conversation

tcappellari-bdai
Copy link
Collaborator

Adds mission services to spot wrapper
Made spot_mission_wrapper.py and added service to MockDirectoryService

Previously, CI got stuck because the service was missing in MockDirectoryService. I ran the tests locally and they all pass now

@tcappellari-bdai tcappellari-bdai force-pushed the SW-949-add-mission-client-in-spot-wrapper branch from 33d9da4 to 9a1781d Compare May 15, 2024 21:11
@coveralls
Copy link

coveralls commented May 15, 2024

Pull Request Test Coverage Report for Build 9102755650

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 46.432%

Files with Coverage Reduction New Missed Lines %
spot_wrapper/spot_dance.py 1 18.52%
Totals Coverage Status
Change from base Build 9085787717: 0.0%
Covered Lines: 1620
Relevant Lines: 3489

💛 - Coveralls

Copy link
Collaborator

@khughes-bdai khughes-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tcappellari-bdai tcappellari-bdai merged commit 20768e6 into main May 15, 2024
6 checks passed
@tcappellari-bdai tcappellari-bdai deleted the SW-949-add-mission-client-in-spot-wrapper branch May 15, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants