-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sw-949] add mission client in spot wrapper #109
Merged
tcappellari-bdai
merged 11 commits into
main
from
SW-949-add-mission-client-in-spot-wrapper
May 15, 2024
Merged
[Sw-949] add mission client in spot wrapper #109
tcappellari-bdai
merged 11 commits into
main
from
SW-949-add-mission-client-in-spot-wrapper
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33d9da4
to
9a1781d
Compare
Pull Request Test Coverage Report for Build 9102755650Details
💛 - Coveralls |
khughes-bdai
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds mission services to spot wrapper
Made
spot_mission_wrapper.py
and added service toMockDirectoryService
Previously, CI got stuck because the service was missing in
MockDirectoryService
. I ran the tests locally and they all pass now