Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAPLE-663] Update gripper_angle_open function #142

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

llee-bdai
Copy link
Collaborator

@llee-bdai llee-bdai commented Sep 24, 2024

This is a slight update to the gripper_angle_open function that already existed in spot_arm.py. Simply Adds a flag to allow running this function without forcing a power on and stand of the robot.
Also a slight update to block_until_gripper_command_completes as all gripper commands were technically failing because the feedback structure perhaps changed recently

@coveralls
Copy link

coveralls commented Sep 24, 2024

Pull Request Test Coverage Report for Build 11054198206

Details

  • 1 of 15 (6.67%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 40.902%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spot_wrapper/spot_arm.py 1 15 6.67%
Files with Coverage Reduction New Missed Lines %
spot_wrapper/spot_arm.py 1 14.42%
Totals Coverage Status
Change from base Build 11054053453: -0.05%
Covered Lines: 1868
Relevant Lines: 4567

💛 - Coveralls

Copy link
Collaborator

@khughes-bdai khughes-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator Author

llee-bdai commented Sep 26, 2024

Merge activity

  • Sep 26, 10:19 AM EDT: @llee-bdai started a stack merge that includes this pull request via Graphite.
  • Sep 26, 10:19 AM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 26, 10:24 AM EDT: Graphite couldn't merge this PR because it failed for an unknown reason.
  • Sep 26, 10:48 AM EDT: @khughes-bdai started a stack merge that includes this pull request via Graphite.
  • Sep 26, 10:49 AM EDT: @khughes-bdai merged this pull request with Graphite.

@llee-bdai llee-bdai force-pushed the ll/maple/update_gripper_angle_open branch from 8fcdb15 to 8d9ce94 Compare September 26, 2024 14:19
@khughes-bdai khughes-bdai merged commit bde75c2 into main Sep 26, 2024
6 checks passed
@khughes-bdai khughes-bdai deleted the ll/maple/update_gripper_angle_open branch September 26, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants