Skip to content

Commit 785aad9

Browse files
committed
Fix pipeline initialisation of wireframe mode (fixes #1609) (#1623)
More details are in the associated issue #1609. While looking for the source of this issue, I've noticed that the `set` and `set_untracked` methods aren't really DRY: https://github.com/bevyengine/bevy/blob/68606934e32ab45828c628e1cefd3873273f8708/crates/bevy_asset/src/assets.rs#L76-L85 https://github.com/bevyengine/bevy/blob/68606934e32ab45828c628e1cefd3873273f8708/crates/bevy_asset/src/assets.rs#L91-L99 Shouldn't `set` call `set_untracked`? Also, given the bug that arose from a misusage of these functions, maybe some refactoring is needed?
1 parent 03601db commit 785aad9

File tree

1 file changed

+1
-1
lines changed
  • crates/bevy_render/src/wireframe

1 file changed

+1
-1
lines changed

crates/bevy_render/src/wireframe/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ impl Plugin for WireframePlugin {
3333
let mut pipelines = world
3434
.get_resource_mut::<Assets<PipelineDescriptor>>()
3535
.unwrap();
36-
pipelines.set(
36+
pipelines.set_untracked(
3737
WIREFRAME_PIPELINE_HANDLE,
3838
pipeline::build_wireframe_pipeline(&mut shaders),
3939
);

0 commit comments

Comments
 (0)