Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make checked vs unchecked shaders configurable #17786

Closed
alice-i-cecile opened this issue Feb 10, 2025 · 0 comments · Fixed by #17824
Closed

Make checked vs unchecked shaders configurable #17786

alice-i-cecile opened this issue Feb 10, 2025 · 0 comments · Fixed by #17824
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon

Comments

@alice-i-cecile
Copy link
Member

I agree that this is unquestionably the better default. I won't push too hard for it in this PR (as this is better and I don't look a gift horse in the mouth), but making this configurable from our Shader type is low hanging fruit, and makes a very valuable and hard-to-implement-yourself feature available to people that want it.

Edit: I don't think doing that needs design work. Just make it an enum on Shader and expose the functionality via a new method on RenderDevice.

Originally posted by @cart in #17767 (review)
@alice-i-cecile alice-i-cecile added C-Feature A new feature, making something new possible A-Rendering Drawing game state to the screen S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Feb 10, 2025
@fjkorf fjkorf mentioned this issue Feb 12, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 20, 2025
@fjkorf @alice-i-cecile
Shader validation enum (#17824)
ed62e59 
# Objective

Make checked vs unchecked shaders configurable
Fixes #17786 

## Solution

Added `ValidateShaders` enum to `Shader` and added
`create_and_validate_shader_module` to `RenderDevice`

## Testing

I tested the shader examples locally and they all worked. I'd like to
write a few tests to verify but am unsure how to start.

---------

Co-authored-by: Alice Cecile <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Shader validation enum fjkorf/bevy
1 participant
@alice-i-cecile