Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DWI derivatives: Provide diffusivity units #53

Closed
wants to merge 3 commits into from

Conversation

Lestropie
Copy link
Collaborator

Draft pull request as I'm undecided myself, and it may require further modification if we commit to it.

How should the units of any model-derived diffusivity parameter be handled?

  1. Compulsory to be specified in JSON
  2. Default units in specification, but can be specified in JSON
  3. Compulsory units in specification

Conflicts:
	src/05-derivatives/05-diffusion-derivatives.md
Conflicts:
	src/05-derivatives/05-diffusion-derivatives.md
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #53 (3e43e31) into bep-016 (e485551) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           bep-016      #53   +/-   ##
========================================
  Coverage    88.53%   88.53%           
========================================
  Files            6        6           
  Lines         1055     1055           
========================================
  Hits           934      934           
  Misses         121      121           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@arokem
Copy link
Collaborator

arokem commented Sep 12, 2022

I like number 2 the best (with mm^2/sec being the default 😄 )

@Lestropie
Copy link
Collaborator Author

With #92, specification-dictated parameters are no longer there. So there's no special allocation for diffusivity over anything else; identification and interpretation of data is up to a combination of entities & metadata contents. If we want to re-introduce those (which there's a valid argument for), then any possible handling of default units for specific parameters would need to be reconsidered from scratch for the full set of proposed baked-in parameters.

@Lestropie Lestropie closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants