Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update or replace sodar_cli for compatibility with Sodar 1.0 release #261

Open
Nicolai-vKuegelgen opened this issue Feb 13, 2025 · 0 comments · May be fixed by #263
Open

Update or replace sodar_cli for compatibility with Sodar 1.0 release #261

Nicolai-vKuegelgen opened this issue Feb 13, 2025 · 0 comments · May be fixed by #263
Assignees

Comments

@Nicolai-vKuegelgen
Copy link
Contributor

Describe the bug
The upcoming SODAR server 1.0 release introduces some small but nonetheless breaking changes to the API (see change-logs).
The current sodar_cli built into cubi-tk can not deal with these changes, primarily because the API return values do not match the models built into sodar_cli. Additioanlly. it also does not support the API versioning that is now being introduced.

Proposed solution

Short-Term:
To build a cubi-tk version that is compatible with SODAR server 1.0, we should:

  • build a new (breaking) sodar_cli release thta omits the model checks. This should allow all (or at least most) functionality needed for cubi-tk to be usable.
  • Test the new cubi-tk build on Sodar staging which already has the new 1.0 version deployed.

Long-Term
The recently added common sodar_api.py already provides the basis for a new implementation of cubi-tk. This should be improved and expanded, to cover all use-cases needed by cubi-tk, so that the "hack" of sodar_cli is not needed anymore.

Proposed solution
If a new maintainer of sodar_cli can be found, then cubi-tk can rely on an updated sodar_cli instead.

@Nicolai-vKuegelgen Nicolai-vKuegelgen changed the title Update or replace sodar_cli for campatibility with Sodar 1.0 release Update or replace sodar_cli for compatibility with Sodar 1.0 release Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants