Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update sodar_cli & python-irods client for base functionality #263

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

Nicolai-vKuegelgen
Copy link
Contributor

@Nicolai-vKuegelgen Nicolai-vKuegelgen commented Feb 14, 2025

Draft PR, basic authentication with sodar API & irods (via pyhton irods clint) seems to work with Sodar v1.0

Main changes:

  • All snappy itransfer functions updated to use python irods
  • Update of sodar_cli commit & python-irods client to be compatible with Sodar v1.0

Functions Confrimed working on staging:

  • cubi-tk snappy pull-sheets
  • cubi-tk sodar landing-zone-create $PROJECT_UUID
  • cubi-tk snappy itransfer-raw-data --yes $PROJECT_UUID
  • cubi-tk snappy itransfer-ngs-mapping --mapper bwa_mem2 --yes $PROJECT_UUID
  • cubi-tk snappy itransfer-variant-calling --caller gatk4_hc_gvcf --mapper bwa_mem2 --yes $PROJECT_UUID
  • cubi-tk snappy itransfer-sv-calling --mapper bwa_mem2 --yes $PROJECT_UUID
  • cubi-tk sodar landing-zone-list $PROJECT_UUID
  • cubi-tk sodar landing-zone-validate LZ_UUID
  • cubi-tk sodar landing-zone-move LZ_UUID
  • cubi-tk snappy pull-raw-data $PROJECT_UUID
    Note: may not find all files? Unlikely to be a newly create issue, but should be investigated
  • cubi-tk sodar ingest-fastq, upload of a few real files
  • cubi-tk sodar ingest-fastq, upload of many many small files
  • cubi-tk sodar pull-data-collection, subset from many small files)
  • cubi-tk sodar add-ped
    Notes: this function assumes we still have Library Name and not 2x Extract Name, as is the case with the current DNA germline template. Also static metadata seems to not be added to index, when used for updating, very unlikely to be caused by the API updates
  • cubi-tk sodar update-samplesheet
    Note: some bugs here when adding new samples, not caused by the API updates

@Nicolai-vKuegelgen Nicolai-vKuegelgen changed the title Update sodar_cli & pyhtoon-irods client for base functionality feat: Update sodar_cli & pyhtoon-irods client for base functionality Feb 14, 2025
@Nicolai-vKuegelgen
Copy link
Contributor Author

Nicolai-vKuegelgen commented Feb 14, 2025

Other issues / side results from upgrading dependencies:

  • logging/stderr output is duplicated (see maybe also Replace logzero as logging solution #172 ). Most likely caused by the irods-pyhton client also using a "logger" object
  • Initial/First irods authentifcation gave weird errors, not observed on subsequent usage

@tedil tedil changed the title feat: Update sodar_cli & pyhtoon-irods client for base functionality feat: Update sodar_cli & python-irods client for base functionality Feb 17, 2025
Copy link
Contributor

Please check your code via make lint.

Sarah Laemmle and others added 6 commits February 19, 2025 15:46
@Nicolai-vKuegelgen
Copy link
Contributor Author

Not touching cubi-tk seasnap itransfer-results for now (apart from giving it all the code removed from snappy/itransfer_common.py), because it relies on a seasnap blueprint that already contains icommands

@Nicolai-vKuegelgen
Copy link
Contributor Author

@tedil can you make sure that the changes to uv.lock are okay?

@Nicolai-vKuegelgen
Copy link
Contributor Author

@mikkonie noticed that the logging might be an issue of the pyhton-irods client, which was fixed in ther version 3.0
irods/python-irodsclient#660

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update or replace sodar_cli for compatibility with Sodar 1.0 release
1 participant