Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#256] support for multiple studies and multiple assays in sodar_common.py #259

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

slaemmle
Copy link
Contributor

added multi study support to assay search in sodar_common.py

@slaemmle slaemmle self-assigned this Feb 13, 2025
Copy link
Contributor

Please check your code via make lint.

Copy link
Contributor

@Nicolai-vKuegelgen Nicolai-vKuegelgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

A project with multiple studies will (essentially) always also have multiple assays (as in at least one assay per study), so the added comment could be updated, but that is a very minor thing.

@slaemmle slaemmle merged commit d9def70 into main Feb 13, 2025
4 checks passed
@slaemmle slaemmle deleted the 256-sodar_common_support_multiple_assays_and_studies branch February 13, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants