Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Drop PP5 and BP6 criteria (#289) #319

Merged
merged 6 commits into from
Dec 21, 2023
Merged

fix: Drop PP5 and BP6 criteria (#289) #319

merged 6 commits into from
Dec 21, 2023

Conversation

gromdimon
Copy link
Contributor

No description provided.

@gromdimon gromdimon linked an issue Dec 20, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d4d949e) 75.71% compared to head (625bf0e) 84.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   75.71%   84.50%   +8.79%     
==========================================
  Files         170       53     -117     
  Lines        6613     1575    -5038     
  Branches     1452        0    -1452     
==========================================
- Hits         5007     1331    -3676     
+ Misses       1419      244    -1175     
+ Partials      187        0     -187     
Files Coverage Δ
backend/app/schemas/acmgseqvar.py 100.00% <ø> (ø)

... and 117 files with indirect coverage changes

@gromdimon gromdimon enabled auto-merge (squash) December 20, 2023 10:27
@gromdimon gromdimon disabled auto-merge December 20, 2023 10:31
@gromdimon gromdimon marked this pull request as draft December 20, 2023 10:31
@holtgrewe holtgrewe marked this pull request as ready for review December 21, 2023 14:19
@holtgrewe holtgrewe enabled auto-merge (squash) December 21, 2023 14:19
@holtgrewe holtgrewe merged commit a328f3a into main Dec 21, 2023
9 checks passed
@holtgrewe holtgrewe deleted the 289-drop-pp5bp6 branch December 21, 2023 14:23
@holtgrewe holtgrewe added this to the 0.3.0 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop PP5/BP6
2 participants