Remove ipv4 v3

[willcl-ark]

Remove the ipv4 stuff (and fixed subnet from compose).

Closes #253

[pinheadmz]

might reconsider keeping this. from the doc:

 --externalhosts=                                      

Add a hostname:port that should be periodically resolved to announce IPs for. If a port is not specified, the default (9735) will be used.

[willcl-ark]

Hmm, not sure what to do here, as we won't know the ip address until after startup in our classic, re-occurring chicken-and-egg problem.

[pinheadmz]

but lightning_dns is a domain name isn't it? Sounds to me like lnd will resolve the IP sometime after startup

[pinheadmz]

Great point actually. So, running warnet+simln locally, simln would be running on the host and not in the docker network at all. It would use the IPs of the lnd nodes inside docker to send RPC commands (remember we made them fix it, bitcoin-dev-project/sim-ln#151).

This may be the only time we explicitly need the actual IP of the lnd node.

Or we could work out how to incorporate sim-ln inside a container in the network, which we will probably need for K8s deployment anyway

[pinheadmz]

Re: #134

Yes this does create each new network with a unique subnet.

Test:

warcli network start --network=wn1
warcli network start --network=wn2
docker inspect wn1 | grep Subnet
docker inspect wn2 | grep Subnet

However I think we could make one additional change to the compose file to make it even more clear in the docker desktop GUI and who knows wherever else:

diff --git a/src/backends/compose/compose_backend.py b/src/backends/compose/compose_backend.py
index ecc067c..7eab535 100644
--- a/src/backends/compose/compose_backend.py
+++ b/src/backends/compose/compose_backend.py
@@ -289,7 +289,7 @@ class ComposeBackend(BackendInterface):
     def _write_docker_compose(self, warnet):
         compose = {
             "version": "3.8",
-            "name": "warnet",
+            "name": warnet.network_name,
             "networks": {
                 warnet.network_name: {
                     "name": warnet.network_name,

[willcl-ark]

Yes this does create each new network with a unique subnet.

I just added the fixed subnet back in. It would seem to me to make things much easier for you on the Tor side, whilst not having much downside for us?

It's compose-only now, and not part of Warnet. (added to compose_backend here (yes I re-organised those other variables in this touch, and what!)

[mplsgrant]

I see some kind of caching issue for warcli network info revealed after doing a warcli network down

[willcl-ark]

I see some kind of caching issue for warcli network info revealed after doing a warcli network down

This should be fixed in a new PR as it's not related to this change

[pinheadmz]

added a commit that puts ipv4 back in the info table, so if warcli network info is called after IPs have been assigned, it makes sense:

(.venv) --> warcli network start test/data/ln.graphml --force
Warnet:
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ Temp dir                    ┃ Bitcoin network ┃ Warnet network name ┃ Graph                                 ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┩
│ /root/.warnet/warnet/warnet │ regtest         │ warnet              │ MultiDiGraph with 5 nodes and 9 edges │
└─────────────────────────────┴─────────────────┴─────────────────────┴───────────────────────────────────────┘

Tanks:
┏━━━━━━━┳━━━━━━━━━┳━━━━━━┳━━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━┓
┃ Index ┃ Version ┃ IPv4 ┃ bitcoin conf  ┃ tc_netem ┃ LN  ┃ LN Image                          ┃ LN IPv4 ┃
┡━━━━━━━╇━━━━━━━━━╇━━━━━━╇━━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━┩
│ 0     │ 27.0    │ None │ -uacomment=w0 │ None     │ lnd │ lightninglabs/lnd:v0.17.5-beta    │ None    │
│ 1     │ 27.0    │ None │ -uacomment=w1 │ None     │ lnd │ lightninglabs/lnd:v0.18.0-beta    │ None    │
│ 2     │ 27.0    │ None │ -uacomment=w2 │ None     │ lnd │ lightninglabs/lnd:v0.18.0-beta    │ None    │
│ 3     │ 27.0    │ None │ -uacomment=w2 │ None     │ cln │ elementsproject/lightningd:v23.11 │ None    │
│ 4     │ 27.0    │ None │ -uacomment=w3 │ None     │     │                                   │         │
└───────┴─────────┴──────┴───────────────┴──────────┴─────┴───────────────────────────────────┴─────────┘
(.venv) --> warcli network info
Warnet:
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ Temp dir                    ┃ Bitcoin network ┃ Warnet network name ┃ Graph                                 ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┩
│ /root/.warnet/warnet/warnet │ regtest         │ warnet              │ MultiDiGraph with 5 nodes and 9 edges │
└─────────────────────────────┴─────────────────┴─────────────────────┴───────────────────────────────────────┘

Tanks:
┏━━━━━━━┳━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┓
┃ Index ┃ Version ┃ IPv4        ┃ bitcoin conf  ┃ tc_netem ┃ LN  ┃ LN Image                          ┃ LN IPv4     ┃
┡━━━━━━━╇━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━┩
│ 0     │ 27.0    │ 10.1.21.205 │ -uacomment=w0 │ None     │ lnd │ lightninglabs/lnd:v0.17.5-beta    │ 10.1.21.214 │
│ 1     │ 27.0    │ 10.1.21.209 │ -uacomment=w1 │ None     │ lnd │ lightninglabs/lnd:v0.18.0-beta    │ 10.1.21.206 │
│ 2     │ 27.0    │ 10.1.21.210 │ -uacomment=w2 │ None     │ lnd │ lightninglabs/lnd:v0.18.0-beta    │ 10.1.21.211 │
│ 3     │ 27.0    │ 10.1.21.207 │ -uacomment=w2 │ None     │ cln │ elementsproject/lightningd:v23.11 │ 10.1.21.212 │
│ 4     │ 27.0    │ 10.1.21.208 │ -uacomment=w3 │ None     │     │                                   │             │
└───────┴─────────┴─────────────┴───────────────┴──────────┴─────┴───────────────────────────────────┴─────────────┘

[m3dwards]

Closing for now because of the new structure which may not have RPC