Various Improvements #1713
Merged
Various Improvements #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varunagrawal
force-pushed
the
model-selection-bayestree
branch
2 times, most recently
from
bf8bc2b to
f62805f
Compare
… as it is possible to have non-zero discrete keys
Some Updates
varunagrawal
force-pushed
the
model-selection-integration
branch
from
d552eef to
538871a
Compare
varunagrawal
changed the title
|
You can cancel that last check and merge, it takes hours. I opened a discussion on killing gcc9 altogether in CI. |
Looks like the issue is gcc9 + TBB but only with the python wrapper. I think we can just get rid of checking with gcc9+TBB but keep gcc9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of improvements to the code, including formatting, more tests and better printing.