[1/N] Split the NoiseModelFactorN to individual header #2301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot finished reviewing on behalf of
ProfFan
November 17, 2025 03:46
Copilot finished reviewing on behalf of
dellaert
November 17, 2025 04:50
Comment on lines
+21
to
+26
| // \callgraph | ||
|
|
||
| #include <gtsam/nonlinear/NonlinearFactor.h> | ||
|
|
||
| #pragma once | ||
|
|
There was a problem hiding this comment.
The #pragma once directive must appear before any #include statements to properly guard the header file against multiple inclusion. Move #pragma once to line 21, before the #include directive.
Suggested change
| // \callgraph | |
| #include <gtsam/nonlinear/NonlinearFactor.h> | |
| #pragma once | |
| #pragma once | |
| // \callgraph | |
| #include <gtsam/nonlinear/NonlinearFactor.h> |
Member
|
I like this! I’ll hold off approving until CI passes, including python wrapper, of course. |
Member
|
Please do provide a PR comment even if you think the title is self-explanatory. And maybe provide a rationale even if what is being done is clear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the large class NoiseModelFactorN to its own header, which will help in future reactors. This necessitated a lot of changes wherever the older header was included.