Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable WebTorrent extension by default #27876

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bsclifton
Copy link
Member

Disables WebTorrent for NEW users only by default.

Existing users will keep their current value. This code will "lock the value in" when it runs the first time.

Fixes brave/brave-browser#44303

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

New user

  1. Blank profile
  2. Launch Brave
  3. Visit brave://settings/extensions
  4. Ensure WebTorrent is set to FALSE

Existing user - explicitly enabled

  1. Have a profile BEFORE this change
  2. Toggle the value for WebTorrent on brave://settings/extensions
    • Disable it
    • Enable it
  3. Launch a version of Brave which has this update
  4. Visit brave://settings/extensions
  5. Verify WebTorrent is set to TRUE

Existing user - they never touched it

  1. Have a profile BEFORE this change
  2. Launch a version of Brave which has this update
  3. Visit brave://settings/extensions
  4. Verify WebTorrent is set to TRUE

Existing user - making a new profile

  1. Do steps for Existing user - they never touched it
  2. Use Hamburger menu > More tools > Add new profile to create a new profile
  3. Visit brave://settings/extensions
  4. Verify WebTorrent is set to FALSE

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ with nits!

@bsclifton bsclifton enabled auto-merge (squash) February 28, 2025 17:20
@bsclifton bsclifton requested a review from iefremov as a code owner February 28, 2025 19:15
@github-actions github-actions bot added the CI/run-network-audit Run network-audit label Feb 28, 2025
@bsclifton bsclifton disabled auto-merge March 1, 2025 00:37
@bsclifton bsclifton force-pushed the bsc-disable-webtorrent-default branch from bfa1d30 to 1200df7 Compare March 1, 2025 00:41
@bsclifton bsclifton force-pushed the bsc-disable-webtorrent-default branch from 1200df7 to ec61fcb Compare March 1, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable WebTorrent handling in Brave by default
2 participants