Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rumqttd): Update rustls and friends. #795

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

qwandor
Copy link
Contributor

@qwandor qwandor commented Feb 9, 2024

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if it's relevant to the users of the library. If it's not relevant mention why.

Copy link
Member

@swanandx swanandx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the PR! 🚀

please feel free to comment on requested changes :)

Copy link
Member

@swanandx swanandx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 ! ( except unresolved questions )

Please lmk if you have tested it, I will also test it once to verify integrity and then we are good to go :)

Thank you so much for your contribution!

@swanandx swanandx merged commit d348710 into bytebeamio:main Feb 14, 2024
3 checks passed
@qwandor qwandor deleted the rustlsd branch February 14, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants