fix: enable calendar sync for API v2 bookings with API key auth #25049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes calcom#25009 API v2 bookings created with API key authentication (non-OAuth) were not syncing to connected calendars or sending confirmation emails. The issue was that areCalendarEventsEnabled flag was only set for OAuth platform bookings but missing for regular API key bookings. Added areCalendarEventsEnabled: true flag to the regular API booking flow in input.service.ts to ensure calendar events are created and confirmation emails are sent for non-OAuth API bookings. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
@vigneshpamu is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
dhairyashiil
previously requested changes
Nov 15, 2025
Member
dhairyashiil
left a comment
dhairyashiil
left a comment
There was a problem hiding this comment.
Please attach before and after loom video, making it draft until then.
3 tasks
|
|
Contributor
E2E results are ready! |
Ryukemeister
approved these changes
Nov 22, 2025
Contributor
Ryukemeister
left a comment
Ryukemeister
left a comment
There was a problem hiding this comment.
LGTM, nice one @vigneshpamu!
Author
Hey, i mistakely closed the PR |
Author
Hey am i supposed to close the PR ? |
anikdhabal
reviewed
Nov 22, 2025
| }; | ||
| } else { | ||
| Object.assign(newRequest, { userId }); | ||
| Object.assign(newRequest, { userId, areCalendarEventsEnabled: true }); |
Contributor
There was a problem hiding this comment.
We already set areCalendarEventsEnabled default to true. So it's not the correct fix
Contributor
|
@vigneshpamu thanks for your work, im investigating the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #25009
API v2 bookings created with API key authentication (non-OAuth) were not syncing to connected calendars or sending confirmation emails. This PR adds the missing
areCalendarEventsEnabled: trueflag tothe regular API booking flow.
Changes Made
apps/api/v2/src/ee/bookings/2024-08-13/services/input.service.tsareCalendarEventsEnabled: trueparameter on line 128 in the non-OAuth booking flow (else block)Before