Language Improvements #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keertyverma
suggested changes
Mar 10, 2025
Comment on lines
+353
to
+360
| if(!this._isValidLanguage(language)) { | ||
| // If invalid language, fallback to plain text | ||
| this.data.language = 'plain'; | ||
| this.data.editorInstance.updateLanguage('none'); | ||
| this._element.querySelector('.editorjs-codeCup_LangDisplay').innerHTML = 'none'; | ||
| this._handleErrorMessage(language); // Show error message | ||
| return false; | ||
| } |
There was a problem hiding this comment.
-
While this approach prevents invalid syntax highlighting, it may negatively impact the user experience by removing their last valid selection.
Would it be better to retain the previously valid language and syntax highlighter instead? This would help ensure users don’t lose their last selection due to an unintended input error.
if(!this._isValidLanguage(language)) {
this._handleErrorMessage(language); // Show an error message for the invalid language
return false;
}- Additionally, if we still want to reset the language to plain text, the language display text should also reflect Plain Text rather than showing none for consistency.
Comment on lines
+55
to
+77
| static getDefaultLanguages() { | ||
| return { | ||
| bash: "Bash", | ||
| c: "C", | ||
| cpp: "C++", | ||
| csharp: "C#", | ||
| css: "CSS", | ||
| go: "Go", | ||
| html: "HTML", | ||
| java: "Java", | ||
| javascript: "JavaScript", | ||
| json: "JSON", | ||
| kotlin: "Kotlin", | ||
| none: "Plain Text", | ||
| php: "PHP", | ||
| python: "Python", | ||
| ruby: "Ruby", | ||
| rust: "Rust", | ||
| sql: "SQL", | ||
| swift: "Swift", | ||
| typescript: "TypeScript", | ||
| }; | ||
| } |
| @@ -25,7 +25,7 @@ | |||
| padding: 5px; | |||
| padding-left: 10px; | |||
| padding-right: 10px; | |||
| right: 0; | |||
| right: 0px; | |||
There was a problem hiding this comment.
If right: 0px is used, the language display name may not be shown properly when a scrollbar is present.
In my PR, I have adjusted this to right: 12px to ensure proper visibility.
| .editorjs-codeCup_languageDropdown { | ||
| /* top:10px; left:100px; */ | ||
| position: fixed; |
There was a problem hiding this comment.
With position:fixed the dropdown is cropped off in mobile devices. Would you be able to retain my changes?
position: absolute;
top: 100%;
left: 0;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes Improvements from @keertyverma and @calumk