-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language Improvements #13
Open
calumk
wants to merge
4
commits into
main
Choose a base branch
from
BRANCH_NAME
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9e35780
feat: Add language selection dropdown for syntax highlighting
keertyverma c12696e
feat: Validate language before updating editor and highlighting syntax
keertyverma 013cd5d
docs: Update README to include language selection feature
keertyverma 7161cb1
Multiple Languages improvements
calumk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
/** | ||
* EditorJsCodeCup Block for the Editor.js. | ||
* | ||
* @author Calum Knott ([email protected]) | ||
* @license The MIT License (MIT) | ||
*/ | ||
* EditorJsCodeCup Block for the Editor.js. | ||
* | ||
* @author Calum Knott ([email protected]) | ||
* @license The MIT License (MIT) | ||
*/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,7 @@ | |
padding: 5px; | ||
padding-left: 10px; | ||
padding-right: 10px; | ||
right: 0; | ||
right: 0px; | ||
bottom: 0; | ||
border-bottom-right-radius: 5px; | ||
border-top-left-radius: 5px; | ||
|
@@ -71,4 +71,65 @@ | |
padding:5px; | ||
display: flex; | ||
justify-content: space-between; | ||
} | ||
} | ||
|
||
.editorjs-codeCup_languageSelectContainer { | ||
position: relative; | ||
} | ||
|
||
.editorjs-codeCup_languageDropdown { | ||
/* top:10px; left:100px; */ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
position: fixed; | ||
background: white; | ||
border: 1px solid #ddd; | ||
padding: 5px; | ||
z-index: 9999; | ||
max-height: 200px; | ||
overflow-y: auto; | ||
box-shadow: 0px 4px 6px rgba(0, 0, 0, 0.1); | ||
border-radius: 5px; | ||
font-size: 14px; | ||
min-width: 150px; | ||
/* The position will need to be set dynamically via JavaScript */ | ||
} | ||
|
||
.editorjs-codeCup_languageOption { | ||
font-size: 14px; | ||
line-height: 20px; | ||
font-weight: 500; | ||
padding: 6px 12px; | ||
cursor: pointer; | ||
border-bottom: 1px solid #f0f0f0; | ||
} | ||
|
||
.editorjs-codeCup_languageOption:hover { | ||
background-color: #f5f5f5; | ||
} | ||
|
||
.editorjs-codeCup_languageErrorMessage { | ||
display: flex; | ||
align-items: center; | ||
gap: 8px; | ||
font-size: 14px; | ||
font-weight: 500; | ||
color: #d9534f; | ||
background: white; | ||
padding: 6px 10px; | ||
margin-top: 8px; | ||
border-left: 4px solid #d9534f; | ||
border-radius: 4px; | ||
} | ||
|
||
.editorjs-codeCup_languageErrorMessage .close-error { | ||
font-size: 18px; | ||
font-weight: bold; | ||
color: black; | ||
background: transparent; | ||
border: none; | ||
cursor: pointer; | ||
transition: color 0.2s ease; | ||
} | ||
|
||
.editorjs-codeCup_languageErrorMessage .close-error:hover { | ||
color: #444; | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
right: 0px
is used, the language display name may not be shown properly when a scrollbar is present.In my PR, I have adjusted this to
right: 12px
to ensure proper visibility.