Support K2. #1212
Merged
Support K2. #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrtwhite
commented
Jan 4, 2024
zipline/src/commonMain/kotlin/app/cash/zipline/internal/bridge/Endpoint.kt
Outdated
Show resolved
Hide resolved
swankjesse
approved these changes
Jan 9, 2024
* trunk: Prepare next development version Prepare version 1.8.0 Clarify the docs on ZiplineLoader.load() (#1223) Fix doc comment for DefaultFreshnessCheckerNotFresh (#1220) EventListener.manifestReady (#1221) Update dependency androidx.lifecycle:lifecycle-runtime-ktx to v2.7.0 (#1218) Update dependency com.github.ajalt.clikt:clikt to v4.2.2 (#1214) Update dependency com.vanniktech:gradle-maven-publish-plugin to v0.27.0 (#1213)
* trunk: Track changes to upload-artifact@v4
* trunk: Update plugin spotless to v6.24.0 (#1225)
colinrtwhite
commented
Jan 15, 2024
| @@ -174,3 +174,5 @@ actual class QuickJs private constructor( | |||
| private external fun gc(context: Long) | |||
| private external fun setMaxStackSize(context: Long, stackSize: Long) | |||
| } | |||
|
|
|||
| internal expect fun loadNativeLibrary() | |||
There was a problem hiding this comment.
This expect declaration is only necessary if we're compiling the zipline runtime with K2 (which won't happen until Kotlin 2.0.0) - can revert if preferred.
Co-authored-by: Jake Wharton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took a quick pass at supporting K2. It might be possible to support both K2 and K1 if that's something we want to do. Else, we could wait to make these changes until K2 is released.Updated so we can support both K1 and K2. This PR also contains a couple smaller changes that aren't strictly necessary unless we're also compiling Zipline with K2. Can revert if preferred.