Fix opting into EngineApi and expect-actual-classes. #1226
Conversation
| @@ -9,10 +9,10 @@ plugins { | |||
| } | |||
|
|
|||
| kotlin { | |||
| sourceSets.all { | |||
There was a problem hiding this comment.
Not sure if this worked previously, but it currently doesn't opt in for the JVM plugin.
There was a problem hiding this comment.
Yeah I've only used this construct with the multiplatform plugin. Probably me copy/pasting too aggressively.
| @@ -33,7 +33,6 @@ auto-service-compiler = { module = "dev.zacsweers.autoservice:auto-service-ksp", | |||
| auto-service-annotations = { module = "com.google.auto.service:auto-service-annotations", version = "1.1.1" } | |||
| binary-compatibility-validator-gradle-plugin = { module = "org.jetbrains.kotlinx.binary-compatibility-validator:org.jetbrains.kotlinx.binary-compatibility-validator.gradle.plugin", version = "0.13.2" } | |||
| cklib-gradle-plugin = { module = "co.touchlab:cklib-gradle-plugin", version = "0.3.0" } | |||
| coil-compose = { module = "io.coil-kt:coil-compose", version = "2.5.0" } | |||
There was a problem hiding this comment.
Noticed this is unused (unfortunately!)
There was a problem hiding this comment.
Ah from emoji probably, before it moved to Redwood.
| @@ -153,6 +153,18 @@ allprojects { | |||
| plugins.withId("org.jetbrains.kotlin.multiplatform") { | |||
| configure<KotlinMultiplatformExtension> { | |||
| jvmToolchain(11) | |||
| @Suppress("OPT_IN_USAGE") | |||
There was a problem hiding this comment.
Who watches the watchmen?
| // https://youtrack.jetbrains.com/issue/KT-61573 | ||
| targets.configureEach { | ||
| compilations.configureEach { | ||
| compilerOptions.configure { |
There was a problem hiding this comment.
Surprised you need this last configure block. I thought compilerOptions returned an object directly on which you could invoke freeCompilerArgs.
There was a problem hiding this comment.
Interestingly it's a different return type for KotlinCompilation and KotlinProjectExtension
| @@ -33,7 +33,6 @@ auto-service-compiler = { module = "dev.zacsweers.autoservice:auto-service-ksp", | |||
| auto-service-annotations = { module = "com.google.auto.service:auto-service-annotations", version = "1.1.1" } | |||
| binary-compatibility-validator-gradle-plugin = { module = "org.jetbrains.kotlinx.binary-compatibility-validator:org.jetbrains.kotlinx.binary-compatibility-validator.gradle.plugin", version = "0.13.2" } | |||
| cklib-gradle-plugin = { module = "co.touchlab:cklib-gradle-plugin", version = "0.3.0" } | |||
| coil-compose = { module = "io.coil-kt:coil-compose", version = "2.5.0" } | |||
There was a problem hiding this comment.
Ah from emoji probably, before it moved to Redwood.
| @@ -9,10 +9,10 @@ plugins { | |||
| } | |||
|
|
|||
| kotlin { | |||
| sourceSets.all { | |||
There was a problem hiding this comment.
Yeah I've only used this construct with the multiplatform plugin. Probably me copy/pasting too aggressively.
expect-actual-classesstarted warning in1.9.20.Pulling this out of #1212.