-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix opting into EngineApi and expect-actual-classes. #1226
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -153,6 +153,18 @@ allprojects { | |
plugins.withId("org.jetbrains.kotlin.multiplatform") { | ||
configure<KotlinMultiplatformExtension> { | ||
jvmToolchain(11) | ||
@Suppress("OPT_IN_USAGE") | ||
compilerOptions { | ||
freeCompilerArgs.addAll("-opt-in=app.cash.zipline.EngineApi") | ||
} | ||
// https://youtrack.jetbrains.com/issue/KT-61573 | ||
targets.configureEach { | ||
compilations.configureEach { | ||
compilerOptions.configure { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Surprised you need this last There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Interestingly it's a different return type for |
||
freeCompilerArgs.addAll("-Xexpect-actual-classes") | ||
} | ||
} | ||
} | ||
} | ||
} | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,7 +33,6 @@ auto-service-compiler = { module = "dev.zacsweers.autoservice:auto-service-ksp", | |
auto-service-annotations = { module = "com.google.auto.service:auto-service-annotations", version = "1.1.1" } | ||
binary-compatibility-validator-gradle-plugin = { module = "org.jetbrains.kotlinx.binary-compatibility-validator:org.jetbrains.kotlinx.binary-compatibility-validator.gradle.plugin", version = "0.13.2" } | ||
cklib-gradle-plugin = { module = "co.touchlab:cklib-gradle-plugin", version = "0.3.0" } | ||
coil-compose = { module = "io.coil-kt:coil-compose", version = "2.5.0" } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Noticed this is unused (unfortunately!) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah from emoji probably, before it moved to Redwood. |
||
dokka-gradle-plugin = { module = "org.jetbrains.dokka:dokka-gradle-plugin", version = "1.9.10" } | ||
duktape = { module = "com.squareup.duktape:duktape-android", version = "1.4.0" } | ||
http4k-core = { module = "org.http4k:http4k-core", version.ref = "http4k" } | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,10 +9,10 @@ plugins { | |
} | ||
|
||
kotlin { | ||
sourceSets.all { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure if this worked previously, but it currently doesn't opt in for the JVM plugin. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah I've only used this construct with the multiplatform plugin. Probably me copy/pasting too aggressively. |
||
languageSettings { | ||
optIn("app.cash.zipline.EngineApi") | ||
} | ||
compilerOptions { | ||
freeCompilerArgs.addAll( | ||
"-opt-in=app.cash.zipline.EngineApi", | ||
) | ||
} | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who watches the watchmen?