Draft for discussion: on sending a signal when networking fails #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingwei99
force-pushed
the
jingwei.IOException
branch
from
14e1d91 to
4ee1c61
Compare
jingwei99
commented
Jan 10, 2024
Comment on lines
+285
to
+287
| } catch (e: IOException) { | ||
| send(LoadResult.Failure(e)) | ||
| return null |
There was a problem hiding this comment.
I started working on the idea of "surfacing networking failure", and realized that for the catch (e: Exception) branch, does send(LoadResult.Failure(e)) already, and the downstream can check the type of the exception and if it's an IOException, the downstream will take it as an networking failure. So the change needed might be adding a documentation about IOException for LoadResult.Failure.
Or maybe I'm missing something / forgot something
There was a problem hiding this comment.
talked over video, we don't need this, closing the draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.