Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper support for caching helm chart from Artifactory. #5123

Merged
merged 1 commit into from
Feb 13, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
helm: explicitly configure helm chart base url
Currently helm index configures URLs to charts with relative path
(see https://ceph.github.io/csi-charts/index.yaml).

Artifactory contains support for virtual repositories. Virtual
repositories are able to cache remote repositories and provide
offline access to those repositories.

In order for this to work correctly, charts must specify absolute base URL to
artifacts.

This commit adds this base URL using argument for helm index command.

URL with previous approach:
```yaml
    urls:
    - cephfs/ceph-csi-cephfs-3.13.0.tgz
```

URL with current approach (my personal "lirt" repo was used to test this, the
MR specifies correct "ceph" path)
```yaml
    urls:
    - https://lirt.github.io/csi-charts/cephfs/ceph-csi-cephfs-3.13.0.tgz
```

Signed-off-by: Ondrej Vasko <ondrej.vaskoo@gmail.com>
Lirt authored and nixpanic committed Feb 13, 2025
commit b0f869e0c4ed54f85d9679b4f2b44a256dffa7e9
2 changes: 1 addition & 1 deletion deploy.sh
Original file line number Diff line number Diff line change
@@ -84,7 +84,7 @@ push_helm_charts() {
popd >/dev/null

pushd "${CHARTDIR}/csi-charts/docs" >/dev/null
helm repo index .
helm repo index . --url "https://ceph.github.io/csi-charts/"
git config user.name "${GITHUB_USER}"
git config user.email "${GITHUB_EMAIL}"
git add --all :/ && git commit -m "Update for helm charts ${PACKAGE}-${VERSION}"