-
Notifications
You must be signed in to change notification settings - Fork 2
fix for overlayed SD folder line #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think this is not the correct fix actually, after updating a few things to make the actions happy and then testing some more I've found some other projects that have that overlayed SD which aren't just single file |
I think the true root cause of this issue is I validated it by modifying this utility to split up the screenshots into with settings and without with this code:
All of the ones I checked with settings.toml have the overlayed SD folder, and all the ones I checkout without settings are correct without the overlay issue. I will add a commit soon with a fix for this as well as the remaining issues that actions is failing for. |
…mmit hooks to newer versions and fix issues flagged by new versions.
Okay the main fix here is a change to the logic that determines the position of the SD folder line to make it account for the existence of settings.toml. The changes in README correct the example commands to use the subcommand The other changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I did not try to think of pathological cases.
resolves: #18
Here is an example of the corrected screenshot generated by this version. This was the example that was linked to in the issue as well.

I also confirmed a few other projects get fixed by this include others inside of FunHouse_IOT_Hub as well as FunHouse_Parking which had the same issue before with over-layed SD line.
Also contains a small correction to the README example commands and a new section showing the help command.