Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix duplicate lib dirs + update actions environment #22

Merged
merged 10 commits into from
Oct 21, 2024

Conversation

FoamyGuy
Copy link
Collaborator

@FoamyGuy FoamyGuy commented Sep 16, 2024

resolves: #15

If the lib directory exists in project_files it will be removed from there, and it's contents will be added to libs so that they get sorted and rendered into the final screenshot in the remaining lib directory along with all of the dependencies that were found from the bundle

get_dependencies() now handles gracefully libraries that aren't in the bundle and thus we don't know about their dependencies. They are added to the list as-is without any dependency information.

I'm pretty sure this PR will be failing actions. It needs some of the infrastructure updates from #21 in order to successfully pass I think. But I omitted them from this PR in order to keep it more contained to a single change and to not duplicate changes across multiple PRs. After #21 is merged I'll come back and re-run the actions and fix anything still causing it to fail.

@FoamyGuy FoamyGuy changed the title fix duplicate lib dirs fix duplicate lib dirs + update actions environment Sep 16, 2024
@FoamyGuy
Copy link
Collaborator Author

I ended up following a red herring for a little while looking for the reason the actions were failing. In the process I noticed that the version of python in use by the build-images action was python 3.8 due to it using ubuntu 20.04. I updated that to ubuntu 24.04 which brings it up to python 3.12, and made it use a venv in order to be compatible. This turned out not to be related to actual problem, but I've left it in because python 3.8 is EOL soon so I think it's good to go ahead and make this update anyway.

Everything else mentioned in the original comment is still accurate.

Copy link
Collaborator

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't test but it sounds like it's resolving a real problem.

# Conflicts:
#	create_requirement_images.py
@FoamyGuy FoamyGuy merged commit 95cef7a into circuitpython:main Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate lib folder
2 participants