-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix duplicate lib dirs + update actions environment #22
Conversation
…tuple instead of None if no custom libs
I ended up following a red herring for a little while looking for the reason the actions were failing. In the process I noticed that the version of python in use by the Everything else mentioned in the original comment is still accurate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't test but it sounds like it's resolving a real problem.
# Conflicts: # create_requirement_images.py
resolves: #15
If the
lib
directory exists inproject_files
it will be removed from there, and it's contents will be added tolibs
so that they get sorted and rendered into the final screenshot in the remaininglib
directory along with all of the dependencies that were found from the bundleget_dependencies()
now handles gracefully libraries that aren't in the bundle and thus we don't know about their dependencies. They are added to the list as-is without any dependency information.I'm pretty sure this PR will be failing actions. It needs some of the infrastructure updates from #21 in order to successfully pass I think. But I omitted them from this PR in order to keep it more contained to a single change and to not duplicate changes across multiple PRs. After #21 is merged I'll come back and re-run the actions and fix anything still causing it to fail.