Include community bundle libs #23
Merged
+61
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # get_imports.py
jepler
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #20
This pr does the following:
Updates the bundle version checking and fetching functionality to accept parameters indicating which bundle to work on instead of hardcoded to Adafruit bundle.
Checks version and fetches community bundle in addition to Adafruit bundle.
Includes community bundle libraries in the screenshot.
Preserves necessary fallback behavior from #22 to allow project specific custom libs which aren't in any bundle to be included in the screenshot
Removes the global var
LATEST_BUNDLE_VERSIONand it's usage.