make sampleUnfiltered respect ExpectOptions and fix eqWishboneS2M bug
#157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmbollen
changed the title
sampleUnfiltered respect ExpectOptions and fix eqWishboneS2M bug
lmbollen
force-pushed
the
lucas/small-wb-fixes
branch
from
3d43c91 to
33865b0
Compare
This function could sample beyond `eoSampleMax`
If the wishbone bus throws an error, `readData` is not valid
lmbollen
force-pushed
the
lucas/small-wb-fixes
branch
from
33865b0 to
8150eae
Compare
martijnbastiaan
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sampleUnfilteredusesExpectOptionsbut does not respecteoSampleMaxeqWishboneS2Mfails on responses with the error flag set and undefinedreadData. Perhaps we should make a customWishboneS2MEqinstance?