Finish replacing client-side group-type eval w/ server-based attributes#105
Closed
yugen wants to merge 1 commit into
Closed
Finish replacing client-side group-type eval w/ server-based attributes#105yugen wants to merge 1 commit into
yugen wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for pointing these out. I've actually got a bit of an omnibus branch in the works (#106) that might not rebase well off of this change (since change to vite moved all of the js code), so I've incorporated your changes to the tip of that branch. I'll close this, recognizing that the fix is being applied elsewhere. |
bpow
added a commit
that referenced
this pull request
Mar 10, 2025
…utes replaces the commit in #105
bpow
added a commit
that referenced
this pull request
Mar 12, 2025
…utes replaces the commit in #105
setiadha-unc
pushed a commit
that referenced
this pull request
Jun 28, 2025
…utes replaces the commit in #105
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We missed a few along the way. This completely removes old references to client-side eval of group type.