Extract ClojureScript REPL creation into cider-cljs.el#3903
Merged
Conversation
Move the ~340-line "ClojureScript REPL creation" section out of cider.el and into its own module. The new file holds: - the cljs-repl registry (cider-cljs-repl-types, cider-register-cljs-repl-type, cider-default-cljs-repl, cider-select-cljs-repl) - per-flavor helpers and init-form builders (cider-shadow-cljs-init-form, cider-figwheel-main-init-form, cider-shadow-select-cljs-init-form, cider-custom-cljs-repl-init-form, the supporting cider--shadow-* / cider--figwheel-main-* utilities) - requirement checks (cider-check-figwheel-requirements, cider-check-shadow-cljs-requirements, etc., plus the ClojureScript/Piggieback presence checks) - the cljs-repl dispatch entry points cider-cljs-repl-form, cider-verify-cljs-repl-requirements, cider--check-cljs - cider--offer-to-open-app-in-browser, used by the cljs jack-in flow The cider-register-cljs-repl-type registry was already a clean seam: the few callers from cider.el (cider--check-cljs, cider-cljs-repl-form, cider--offer-to-open-app-in-browser) still reach the new file via require. cider-cljs.el itself only needs cider-client (for cider-library-present-p, cider-sync-tooling-eval) and nrepl-dict. cider.el drops from 1801 to 1463 lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure extraction follow-up to #3902. Moves the ~340-line "ClojureScript REPL creation" section out of
cider.elinto its owncider-cljs.elmodule: the cljs-repl registry (cider-cljs-repl-types,cider-register-cljs-repl-type), per-flavor init-form builders (figwheel, figwheel-main, shadow-cljs, krell, custom), requirement checks, the dispatch entry points (cider-cljs-repl-form,cider-verify-cljs-repl-requirements,cider--check-cljs), andcider--offer-to-open-app-in-browserwhich is used by the cljs jack-in flow.The
cider-register-cljs-repl-typeregistry was already a clean seam — the few callers from cider.el reach the new file via require, and the new file only needscider-clientandnrepl-dict. No behavior changes.cider.eldrops from 1801 to 1463 lines.eldev compile --warnings-as-errorseldev test)