add complete node:url implementation #2967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Oct 21, 2024
anonrig
force-pushed
the
yagiz/add-nodejs-url
branch
from
1ad2c26 to
d748c81
Compare
anonrig
commented
Oct 21, 2024
| this.pathname = null; | ||
| this.path = null; | ||
| this.href = null; | ||
| } as unknown as { |
There was a problem hiding this comment.
@mikea any suggestions on making this more maintainable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds all remaining functionality for removing the requirement of the polyfill from wrangler for
node:urlmodule. (We can remove the hybrid polyfill). It is important to add the remaining modules becausenode:urlis one of the most used modules in the ecosystem.Here's the functionality implemented:
new Url()classurl.urlToHttpOptionsurl.format()url.parse()url.resolve()url.resolveObject()