Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence gcc 13.3.0 spurious array bounds warnings for std::vector initialization #47259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gartung
Copy link
Member

@gartung gartung commented Feb 4, 2025

gcc 13.3 produces spurious array bounds warning/error for std::vector initialization with curly braces.
addresses
#47218
#47219
#47220
#47221
#47222

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2025

A new Pull Request was created by @gartung for master.

It involves the following packages:

  • CondFormats/JetMETObjects (db)
  • L1Trigger/TrackFindingTMTT (l1)
  • L1Trigger/TrackFindingTracklet (l1)
  • PhysicsTools/MVAComputer (ml)
  • RecoEgamma/EgammaIsolationAlgos (reconstruction)
  • RecoTauTag/RecoTau (reconstruction)

@aloeliger, @atpathak, @cmsbuild, @consuegs, @epalencia, @francescobrivio, @jfernan2, @mandrenguyen, @perrotta, @valsdav, @y19y19 can you please review it and eventually sign? Thanks.
@AlexDeMoor, @JanChyczynski, @Martin-Grunewald, @Ming-Yan, @PonIlya, @Prasant1993, @Sam-Harper, @Senphy, @a-kapoor, @afiqaize, @ahinzmann, @andrzejnovak, @azotz, @castaned, @erikbutz, @gkasieczka, @jainshilpi, @jdamgov, @jdolen, @lgray, @mariadalfonso, @mbluj, @missirol, @mmarionncern, @mmusich, @nhanvtran, @ram1123, @rappoccio, @rsreds, @sameasy, @schoef, @seemasharmafnal, @skinnari, @sobhatta, @valsdav, @varuns23, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@gartung
Copy link
Member Author

gartung commented Feb 4, 2025

please test for el8_amd64_gcc13

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d80b39/44192/summary.html
COMMIT: 21fce4b
CMSSW: CMSSW_15_0_X_2025-02-03-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47259/44192/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 97 lines from the logs
  • Reco comparison results: 76774 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4016938
  • DQMHistoTests: Total failures: 477325
  • DQMHistoTests: Total nulls: 301
  • DQMHistoTests: Total successes: 3539292
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4.671 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.352 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): -0.104 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 145.604 ): 0.051 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 17034.0 ): 0.352 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.176 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.098 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 6.046 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): -1.048 KiB SiStrip/MechanicalView
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 16 / 48 workflows

@perrotta
Copy link
Contributor

perrotta commented Feb 5, 2025

+db

  • (Technical, for the test area of CondFormats/JetMETObjects)

@jfernan2
Copy link
Contributor

jfernan2 commented Feb 5, 2025

+1

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2025

Milestone for this pull request has been moved to CMSSW_15_1_X. Please open a backport if it should also go in to CMSSW_15_0_X.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants