feat: unbundle delphi-logger and re-export it in delphi-utils #1970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshemetov
force-pushed
the
ds/logger
branch
2 times, most recently
from
ff93c62 to
1a9ceb0
Compare
4 tasks
|
See this snag here. |
nmdefries
approved these changes
Jun 17, 2024
| pool.join() | ||
| finally: | ||
| logger_thread.stop() | ||
| from delphi_logger import get_structured_logger # pylint: disable=unused-import |
There was a problem hiding this comment.
question: this bit does the reexporting?
| get_structured_logger | ||
| from typing import Any, Dict | ||
|
|
||
| from delphi_utils import add_prefix, create_export_csv, get_structured_logger, pool_and_threadedlogger |
There was a problem hiding this comment.
question: but in delphi_utils, we're only reexporting get_structured_logger, so won't importing pool_and_threadedlogger here fail?
| @@ -1,255 +1,10 @@ | |||
| """Structured logger utility for creating JSON logs. | |||
| """Temporary migration compatibility file. | |||
There was a problem hiding this comment.
note: we'll need a followup issue once we remove this file to make sure that other logger imports continue to work, e.g..
|
Closed for another approach (see comment here). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor
delphi-utilsto depend ondelphi-loggerstandalone repo.Changelog
logger.pyto the standalone delphi-logger repo.delphi-utilsand re-export it, so thatfrom delphi-utils import get_structured_loggerstill works.Fixes