Skip to content

hardhat quantiles #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Mar 12, 2025
Merged

hardhat quantiles #443

merged 22 commits into from
Mar 12, 2025

Conversation

dajmcdon
Copy link
Contributor

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers:
    dajmcdon.
  • Make sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).

Change explanations for reviewer

This PR replaces dist_quantiles(), a custom distribution related to the distributional package, with quantile_pred() from the hardhat package. This is one step in off-loading some custom components to core tidymodels functionality.

Replaces #442

@dajmcdon dajmcdon mentioned this pull request Feb 26, 2025
3 tasks
@dajmcdon dajmcdon linked an issue Feb 26, 2025 that may be closed by this pull request
@dsweber2 dsweber2 self-assigned this Mar 11, 2025
Copy link
Contributor

@dsweber2 dsweber2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally lgtm, very minor notes and added a test for pivot_longer with more than 1 row.

@dajmcdon dajmcdon merged commit dc5c7ac into dev Mar 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extrapolate_quantiles and thresholding
2 participants